src/test/java/com/flowingcode/vaadin/addons/imagecrop/test/ImageCropTest.java (1)

48-61: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider adding tests for default (auto-detect) state.

These tests only verify explicit set/get round-trips. The PR's headline feature is auto-detection when outputMimeType/outputQuality are left unset (null). Consider adding a test asserting getOutputMimeType() returns null by default (before any setOutputMimeType call) to lock in the auto-detect contract.

✅ Suggested additional test

+  `@Test`
+  public void testGetOutputMimeTypeDefaultsToNull() {
+    assertNull(imageCrop.getOutputMimeType());
+  }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/flowingcode/vaadin/addons/imagecrop/test/ImageCropTest.java`
around lines 48 - 61, Add a test in ImageCropTest that exercises the default
auto-detect state before any setters are called: verify
imageCrop.getOutputMimeType() returns null initially, and if applicable do the
same for outputQuality. Use the existing ImageCrop test fixture and the
getOutputMimeType()/getOutputQuality() accessors to lock in the unset/null
contract, instead of only testing set/get round-trips.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java (1)

387-389: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider validating outputQuality bounds.

setOutputQuality accepts any double with no range check, though the Javadoc states "a value between 0 and 1". Out-of-range values are silently passed through to canvas.toDataURL on the client.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java` around
lines 387 - 389, `ImageCrop.setOutputQuality` currently passes any double
through without enforcing the documented 0-to-1 range. Add validation in this
setter to reject or clamp out-of-bounds values before calling
`setState("outputQuality", ...)`, so the method matches its Javadoc and only
sends valid quality values to the client.

src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java (1)

340-392: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract property-name constants to fix SonarCloud duplication failures.

"outputMimeType" and "outputQuality" are each repeated 3 times (setter, getPropertyRaw check, getState call). SonarCloud flags both as quality-gate failures.

♻️ Proposed fix

+  private static final String OUTPUT_MIME_TYPE_PROPERTY = "outputMimeType";
+  private static final String OUTPUT_QUALITY_PROPERTY = "outputQuality";
+
   public void setOutputMimeType(String outputMimeType) {
-    setState("outputMimeType", outputMimeType);
+    setState(OUTPUT_MIME_TYPE_PROPERTY, outputMimeType);
   }

   public String getOutputMimeType() {
-    if (getElement().getPropertyRaw("outputMimeType") == null) {
+    if (getElement().getPropertyRaw(OUTPUT_MIME_TYPE_PROPERTY) == null) {
       return null;
     }
-    return getState("outputMimeType", String.class);
+    return getState(OUTPUT_MIME_TYPE_PROPERTY, String.class);
   }

   public void setOutputQuality(double outputQuality) {
-    setState("outputQuality", outputQuality);
+    setState(OUTPUT_QUALITY_PROPERTY, outputQuality);
   }

   public double getOutputQuality() {
-    if (getElement().getPropertyRaw("outputQuality") == null) {
+    if (getElement().getPropertyRaw(OUTPUT_QUALITY_PROPERTY) == null) {
       return 1.0;
     }
-    return getState("outputQuality", Double.class);
+    return getState(OUTPUT_QUALITY_PROPERTY, Double.class);
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java` around
lines 340 - 392, The ImageCrop output property names are duplicated in multiple
places, triggering SonarCloud duplication warnings. Extract shared constants for
the state keys used by setOutputMimeType/getOutputMimeType and
setOutputQuality/getOutputQuality, and reuse those constants in the setState,
getPropertyRaw, and getState calls. Keep the existing behavior unchanged while
centralizing the literal names in ImageCrop.

Source: Linters/SAST tools